hy144328 commented on PR #42365: URL: https://github.com/apache/superset/pull/42365#issuecomment-5064746276
> Bito's note about the redundant future=True in tags/models.py (the sessionmaker already sets it) is also legit if you feel like trimming it. That is right. I thought about it when grepping `sessionmaker(`, and forgot about it when grepping `Session(` after all those migration scripts. Will do so immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
