codeant-ai-for-open-source[bot] commented on code in PR #42470: URL: https://github.com/apache/superset/pull/42470#discussion_r3656273428
########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -1824,11 +1818,9 @@ msgstr "" "disponibles" msgid "An error occurred while fetching available themes" -msgstr "Une erreur s'est produite lors de l'extraction des Thèmes " - -#, fuzzy -msgid "An error occurred while fetching available views" -msgstr "Une erreur s'est produite lors de l'extraction des Thèmes " +msgstr "Une erreur s'est produite lors de la récupération des thèmes disponibles" +"Une erreur s'est produite lors de l'extraction des modèles de CSS " +"disponibles" Review Comment: **Suggestion:** The translation for the themes-fetching error accidentally includes the full translation of the preceding CSS-template message as an additional continuation string. Users will see both unrelated messages concatenated together; remove the extra continuation line. [logic error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ French theme-loading errors contain unrelated CSS text. - ⚠️ Users receive confusing feedback in theme management. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Run Superset with the French locale enabled so gettext loads `superset/translations/fr/LC_MESSAGES/messages.po`. 2. Trigger the UI operation that fetches available themes, which looks up the msgid `An error occurred while fetching available themes` at `superset/translations/fr/LC_MESSAGES/messages.po:1820`. 3. Gettext concatenates the continuation strings at lines 1821-1823 into one translation because adjacent quoted strings form a single `msgstr`. 4. Observe the resulting error text: `Une erreur s'est produite lors de la récupération des thèmes disponiblesUne erreur s'est produite lors de l'extraction des modèles de CSS`, incorrectly appending the unrelated CSS-template message. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f2e93bee35d94d27a1aca65138902cac&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f2e93bee35d94d27a1aca65138902cac&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 1820:1823 **Comment:** *Logic Error: The translation for the themes-fetching error accidentally includes the full translation of the preceding CSS-template message as an additional continuation string. Users will see both unrelated messages concatenated together; remove the extra continuation line. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=0b3b58f16f4fb723cbd3b55df2512089cd3e5ce63dfd43c2b7caf9f5d83bef4b&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=0b3b58f16f4fb723cbd3b55df2512089cd3e5ce63dfd43c2b7caf9f5d83bef4b&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -18029,7 +17722,7 @@ msgid "Week ending Saturday" msgstr "Semaine se terminant le samedi" msgid "Week ending Sunday" -msgstr "Semaine terminant le Dimanche" +msgstr "Semaine se terminant le dimanche" Review Comment: **Suggestion:** The translation contradicts the source string: “Week ending Saturday” is translated as ending on Sunday. This will display the wrong weekday in the French UI; change it to Saturday. [possible bug] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Weekly time-grain options show the wrong weekday. - ⚠️ French users may choose an unintended week boundary. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Run Superset with French translations enabled and open a chart or time-grain control that displays the `Week ending Saturday` msgid from `superset/translations/fr/LC_MESSAGES/messages.po:17724`. 2. The gettext lookup returns the catalog value at line 17725, `Semaine se terminant le dimanche`. 3. Observe that the option presented to the user says the week ends Sunday even though the source option explicitly specifies Saturday. 4. Select that option in a weekly time configuration and observe the incorrect weekday description in the French UI. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c71323d0123f46f3b09ba10c3a5b06a9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c71323d0123f46f3b09ba10c3a5b06a9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 17724:17725 **Comment:** *Possible Bug: The translation contradicts the source string: “Week ending Saturday” is translated as ending on Sunday. This will display the wrong weekday in the French UI; change it to Saturday. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=9561f9afcb05bcbd769370b86f1f38653cc7fe092b26f489d2179b5b0184a2f1&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=9561f9afcb05bcbd769370b86f1f38653cc7fe092b26f489d2179b5b0184a2f1&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -6390,25 +6361,22 @@ msgstr "Activer les prévisions" msgid "Enable graph roaming" msgstr "Activer le déplacement graphique" -# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja, -# lv, pt_BR, ru, sk, sr, sr_Latn, tr, uk] -#, fuzzy +msgid "Enable horizontal layout (columns)" +msgstr "Activer la disposition horizontale (colonnes)" msgid "Enable icon JavaScript mode" msgstr "Activer le mode JavaScript pour les icônes" -#, fuzzy msgid "Enable icons" -msgstr "Colonnex du tableau" +msgstr "Activer les icônes" # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja, # lv, pt_BR, ru, sk, sr, sr_Latn, tr, uk] #, fuzzy msgid "Enable label JavaScript mode" msgstr "Activer le mode JavaScript pour les étiquettes" -#, fuzzy msgid "Enable labels" -msgstr "Étiquettes d’intervalle" +msgstr "Activer les balises" Review Comment: **Suggestion:** `labels` refers to displayed labels, not tags or “balises”. This translation changes the meaning of the control and can confuse users about whether chart labels or tags are being enabled. [possible bug] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Chart configuration labels are confused with metadata tags. - ⚠️ French users may misunderstand label-display controls. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Run Superset with French translations enabled and open a chart configuration containing the `Enable labels` control from `superset/translations/fr/LC_MESSAGES/messages.po:6378`. 2. The gettext lookup uses the translation at line 6379, `Activer les balises`. 3. Observe that the control is labeled as enabling tags, although the surrounding catalog entries at lines 6375-6380 distinguish labels from JavaScript label configuration. 4. Compare the control with chart-label settings such as `Show Labels` at `superset/translations/fr/LC_MESSAGES/messages.po:13167`; the French wording can lead users to interpret the option as metadata tags rather than displayed chart labels. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bdf42c705a37408bb67228d047cbc406&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bdf42c705a37408bb67228d047cbc406&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 6378:6379 **Comment:** *Possible Bug: `labels` refers to displayed labels, not tags or “balises”. This translation changes the meaning of the control and can confuse users about whether chart labels or tags are being enabled. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=9d3773f1f865af6d3a9d061a95fef51c0082163d354f64c0392bcc084706447b&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=9d3773f1f865af6d3a9d061a95fef51c0082163d354f64c0392bcc084706447b&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
