codeant-ai-for-open-source[bot] commented on code in PR #42470: URL: https://github.com/apache/superset/pull/42470#discussion_r3658422128
########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -12561,38 +12400,34 @@ msgid "Select a dashboard" msgstr "Sélectionner un tableau de bord" msgid "Select a database" -msgstr "Sélectionner la base de données" +msgstr "Sélectionner une base de données" msgid "Select a database table and create dataset" msgstr "Sélectionner une table de base de données et créer un jeu de données" -#, fuzzy msgid "Select a database table." -msgstr "Supprimer un tableau de base de données." +msgstr "Sélectionner un tableau de base de données." Review Comment: **Suggestion:** In this database context, “table” is translated as “tableau,” which conventionally means a board or chart rather than a database table. Use “table” to avoid confusing the database-table selection UI with dashboards or visualizations. [possible bug] <details> <summary><b>Severity Level:</b> Minor 🧹</summary> ```mdx - ⚠️ Database table selection wording is ambiguous. - ⚠️ Users may confuse tables with dashboard visualizations. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Start Superset with French selected and enter a workflow that asks the user to choose a database table. 2. The UI looks up `Select a database table.` from `superset/translations/fr/LC_MESSAGES/messages.po:12408`. 3. The catalog displays `Sélectionner un tableau de base de données.` from line 12409. 4. Observe that `tableau` commonly denotes a board, chart, or dashboard in Superset terminology; `table` is the precise French database term and avoids ambiguity. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d5ea2ac18dc643efadb8b35b56c79302&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d5ea2ac18dc643efadb8b35b56c79302&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 12408:12409 **Comment:** *Possible Bug: In this database context, “table” is translated as “tableau,” which conventionally means a board or chart rather than a database table. Use “table” to avoid confusing the database-table selection UI with dashboards or visualizations. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=75bed6a3bdeb572235737fc20da2766fc8240bca2df33ed0ade003ab0e36c9a4&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=75bed6a3bdeb572235737fc20da2766fc8240bca2df33ed0ade003ab0e36c9a4&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -6390,25 +6359,22 @@ msgstr "Activer les prévisions" msgid "Enable graph roaming" msgstr "Activer le déplacement graphique" -# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja, -# lv, pt_BR, ru, sk, sr, sr_Latn, tr, uk] -#, fuzzy +msgid "Enable horizontal layout (columns)" +msgstr "Activer la disposition horizontale (colonnes)" msgid "Enable icon JavaScript mode" msgstr "Activer le mode JavaScript pour les icônes" -#, fuzzy msgid "Enable icons" -msgstr "Colonnex du tableau" +msgstr "Activer les icônes" # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja, # lv, pt_BR, ru, sk, sr, sr_Latn, tr, uk] #, fuzzy msgid "Enable label JavaScript mode" msgstr "Activer le mode JavaScript pour les étiquettes" -#, fuzzy msgid "Enable labels" -msgstr "Étiquettes d’intervalle" +msgstr "Activer les balises" Review Comment: **Suggestion:** The translation uses “balises,” which means HTML tags or labels in a tagging context, for chart labels. This makes the label configuration option misleading; translate it as “étiquettes.” [possible bug] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Chart label controls are misleading for French users. - ⚠️ Users may confuse labels with tagging functionality. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Start Superset with French selected so `superset/translations/fr/LC_MESSAGES/messages.po:6376-6377` is loaded. 2. Open a chart configuration that exposes the `Enable labels` visualization control. 3. The gettext lookup for `Enable labels` returns `Activer les balises` from `messages.po:6377`. 4. Observe that `balises` suggests tags or markup, while the control enables chart labels and should be translated as `étiquettes`. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4f404daa27ed4e1280170415b62f6501&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4f404daa27ed4e1280170415b62f6501&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 6376:6377 **Comment:** *Possible Bug: The translation uses “balises,” which means HTML tags or labels in a tagging context, for chart labels. This makes the label configuration option misleading; translate it as “étiquettes.” Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=729483cb984fc51f08da1cf0233a69ba61d6a6051da1c49ded48fee71581b6dc&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=729483cb984fc51f08da1cf0233a69ba61d6a6051da1c49ded48fee71581b6dc&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -17217,25 +16939,21 @@ msgstr "" "Une erreur inattendue s'est produite, veuillez consulter vos journaux " "pour plus de détails" -#, fuzzy msgid "Unexpected error: " msgstr "Erreur inattendue :" -#, fuzzy msgid "Unexpected no file extension found" -msgstr "Aucune expression sauvegardée n'a été trouvée" +msgstr "Extension de fichier trouvée inattendue" Review Comment: **Suggestion:** The translation says that an unexpected file extension was found, but the source says that no file extension was found. This reverses the error condition and can mislead users troubleshooting file uploads. [logic error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ French upload troubleshooting gives the wrong diagnosis. - ⚠️ Users may not know to provide a filename extension. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Start Superset with French selected and enter a file-upload flow that validates an uploaded file. 2. When the upload has no detectable extension, the application looks up `Unexpected no file extension found` in `superset/translations/fr/LC_MESSAGES/messages.po:16945`. 3. The catalog returns `Extension de fichier trouvée inattendue` from line 16946. 4. Observe that the French message states that an unexpected extension was found, rather than explaining that no extension was found. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9cb52adaa22c42f28ca45817a9acc5bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9cb52adaa22c42f28ca45817a9acc5bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 16945:16946 **Comment:** *Logic Error: The translation says that an unexpected file extension was found, but the source says that no file extension was found. This reverses the error condition and can mislead users troubleshooting file uploads. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=8842edae33a2b4800d22a67dd78818bbd408032b7d490ead4b771ed6bcc9fe70&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42470&comment_hash=8842edae33a2b4800d22a67dd78818bbd408032b7d490ead4b771ed6bcc9fe70&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
