rusackas commented on PR #42577:
URL: https://github.com/apache/superset/pull/42577#issuecomment-5124066371
Bot feedback below... let me know if you want to address any of this (or
would like me to on your behalf) before merging.
### Correctness
- **`The %(key)s in metadata_cache_timeout must be a non-negative
integer.`** — "La clé %(key)s … doit être un entier positif ou nul" states that
the *key* must be an integer, but it's the value. Suggest: `La valeur de
%(key)s dans metadata_cache_timeout doit être un entier positif ou nul.`
- **`Report Schedule executor user %(username)s was not found.`** — the
placeholder position makes it read as though the schedule is named
`%(username)s`. Suggest: `L'utilisateur %(username)s exécutant la planification
de rapport est introuvable.`
- **`The chat failed to load.`** — "Le chat" reads as "the cat" to a French
speaker. Suggest: `La conversation n'a pas pu être chargée.`
- **`Celery broker`** — "courtier" is finance vocabulary. French technical
usage keeps "broker", or "courtier de messages" if you want it translated.
### Placeholder gender and elision
Not something you can fully solve in the `.po` file, but flagging it:
- `%(alertType)s « %(alertName)s » déclenché avec succès` — breaks agreement
if `alertType` resolves to "Alerte" (→ *déclenchée*).
- `Échec du déclenchement de %(alertType)s` — produces "de Alerte" rather
than "de l'alerte".
If these matter, the fix is upstream in the source strings rather than here.
### Terminology consistency with the existing file
Several new strings use better French than their neighbors, which
unfortunately introduces inconsistency. Either align with the existing choices
or fix the neighbors in this same PR — but the file shouldn't ship with both.
- **dataset**: new strings use "ensemble de données"; the file uses "jeu de
données" throughout.
- **tag**: new strings use "étiquette"; existing entries use "balise"
("Balise créée", "Nom de la balise"). "étiquette" also collides with the
existing rendering of "label".
- **Time Grain**: "granularité temporelle" here vs. "Fragment de temps" /
"Fragmentation de Temps" elsewhere.
- **Register**: new "Sélectionnez ou saisissez…" and "Recherchez un canal…"
(imperative) sit directly beside existing "Sélectionner ou renseigner…" and
"Rechercher des enregistrements" (infinitive). This file leans infinitive.
- **Format phrasing**: `Send as Excel` → "au format Excel" vs. existing
"comme CSV" / "comme PDF"; `Formatted Excel attached in email` → "mis en forme
joint au courriel" vs. existing "formatté attaché dans le courriel".
### Minor
- `Show a draggable slider to control the visible range of the Y-axis.` is
on a single ~83-character line; the next `pybabel update` will rewrap it and
create diff noise. Worth wrapping manually.
- "invalide" in the two adhoc-metric strings — "non valide" is the more
correct form.
- "Consultez la console de développement pour le détail" → "pour plus de
détails".
- `You must be a dataset editor in order to edit…` looks like the only one
of those six permission strings left unfilled. Intentional, or an accidental
omission?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
