0xdorian-sm commented on PR #42577: URL: https://github.com/apache/superset/pull/42577#issuecomment-5132816779
Thanks — this was a useful pass and it turned up more than I expected. Three commits pushed. Here's where I landed on each point. **Applied as suggested** - `metadata_cache_timeout` — you're right, the constraint is on the value, not the key. Now reads "La valeur de %(key)s dans metadata_cache_timeout…". - `Report Schedule executor user` — placeholder moved next to "utilisateur". - `The chat failed to load` — "conversation". "Le chat" was genuinely bad and I'm not sure how I let it through. - `Celery broker` — now "broker". For what it's worth, this is the only entry in the whole catalogue whose English mentions a broker, so there was no precedent to break in either direction. - **tag → "balise"**, two entries. You were right and I was wrong here: "balise" runs 20 against "étiquette" at 8, and "étiquette" is already rendering `label` in 75 of the 89 entries where that term appears, so the collision you pointed at is real. - **Register** — the four selection labels are infinitive now. - **dev console** — I aligned the whole string with its pre-existing sibling `Something went wrong with embedded authentication…`, which already says "Consultez la console développeur pour plus de détails". Both halves match now, not just the tail. **Where I checked and the file disagrees with you** I ran counts over `master` rather than trust either of our impressions. Restricting to entries whose msgid contains the English term and is under 70 characters: - **dataset** — "ensemble de données" 58, "jeu de données" 28. Globally 78 to 49. That's 2:1 in the opposite direction from "the file uses *jeu de données* throughout", so I've kept mine. I think I see what you saw, though: in the family of six `You must be a … editor in order to …` strings, the five I translated say "ensemble de données" and the one pre-existing entry says "jeu de données". Locally I do look like the odd one out. - **invalide** — 42, against "non valide" at 6 and "pas valide" at 10. Applying your suggestion to my two adhoc-metric strings would produce exactly the inconsistency you object to two paragraphs above, so I've left them alone. - **`You must be a dataset editor in order to edit…`** — not an omission, it's already translated on `master`. The only two empty msgstr left in the file are `schema1,schema2` and `superset.example.com`, which are example values. After this PR the French catalogue sits at 5080/5082. - **The 83-column line** — you're right that it's 83 columns, so I went to check. Babel compares the content plus its two quotes against `width`, without counting the eight columns of the `msgstr ` prefix. Measured with breakable strings: 74 characters stays on one line, 75 wraps. Mine is 74. I pushed it through `write_po` anyway and it came back byte-identical. `master` also already carries continuation lines of 77 to 80 columns, produced by the tooling itself. **Time Grain and Send as Excel** You offered these as a follow-up, but they're small enough to settle here. - **Time Grain** — the counts really are split (6 against 5), so there's no established choice to defer to. What decided it is that `Time granularity` already renders as "Granularité temporelle", which is a different field; my string was using one field's name for another. It now reads "Le fragment de temps doit être précisé lors de l'utilisation de la comparaison de temps", matching both labels as they appear on screen. - **Send as Excel** — aligned to the neighbours. Four existing entries say "Envoyer comme", none of them wrong, and changing one is cheaper than changing four. - **Formatted Excel** — here I went the other way and fixed the neighbour instead, because aligning would have propagated "formatté" (one t) and "attaché dans le courriel". `Formatted CSV attached in email` is now "Fichier CSV mis en forme joint au courriel". I also fixed "**Text** encapsulé" → "Texte" next door — same family, seemed silly to leave it. **Two things I found on the way** - `fr/LC_MESSAGES/messages.po` has a line reading `, python-format`, without the `#`. The `.pot` has it and so do all 28 other locales; fr is the only one that lost it. One-character fix, included here. To be straight about the impact: Babel still infers `python-format` from the `%s`, so nothing is actually being skipped — it's hygiene, and it silences a parse warning. - On `%(alertType)s`: the problem is worse than agreement. `alertType: alert.type` in `AlertReportList/index.tsx` (lines 198 and 206) never goes through `t()`, and the stored values are the literals `'Alert'` and `'Report'`. So the French toast reads "Alert « … » déclenché avec succès" — an untranslated English noun dropped into a French sentence. No `.po` wording fixes it. I can open a separate issue if that's worth tracking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
