rusackas commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3707305342
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -470,13 +486,14 @@ const DashboardBuilder = () => {
dashboardFiltersOpen,
toggleDashboardFiltersOpen,
nativeFiltersEnabled,
+ hasFilters,
} = useNativeFilters();
const [containerRef, isSticky] = useElementOnScreen<HTMLDivElement>(
ELEMENT_ON_SCREEN_OPTIONS,
);
- const showFilterBar = !editMode && nativeFiltersEnabled;
+ const showFilterBar = isNotMobile && !editMode && nativeFiltersEnabled;
Review Comment:
That's a real gap - the docs for this feature say embedded dashboards are
unaffected since the embedded SDK controls its own layout, but nothing here
actually excludes standalone/embedded from the mobile branch, so a narrow
standalone=2 view does lose native filters with no way to reach them. I don't
want to guess at the fix here since it is a real design call: either mobile
mode should bail out entirely for embedded/standalone (matching what the docs
already promise), or the drawer needs a trigger that doesn't live inside
DashboardHeader. Leaving this open for a closer look rather than patching it
blind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
