codeant-ai-for-open-source[bot] commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3707329820
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -372,6 +386,8 @@ const DashboardBuilder = () => {
const dispatch = useDispatch();
const uiConfig = useUiConfig();
const theme = useTheme();
+ const isNotMobile = !useIsMobile();
+ const [mobileFiltersOpen, setMobileFiltersOpen] = useState(false);
Review Comment:
**Suggestion:** The drawer's open state is retained while the drawer is
unmounted on desktop. If a user opens filters on mobile, grows the viewport
past the breakpoint, and then shrinks it again, the drawer remounts with
`mobileFiltersOpen` still true and opens unexpectedly. Reset the state when
leaving mobile mode or when the drawer is unmounted. [stale reference]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Dashboard filters drawer reopens after viewport resizing.
- โ ๏ธ Users must manually close an unexpected mobile drawer.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b15282c59177438f94dd4c9d3f0b3925&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b15282c59177438f94dd4c9d3f0b3925&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
**Line:** 390:390
**Comment:**
*Stale Reference: The drawer's open state is retained while the drawer
is unmounted on desktop. If a user opens filters on mobile, grows the viewport
past the breakpoint, and then shrinks it again, the drawer remounts with
`mobileFiltersOpen` still true and opens unexpectedly. Reset the state when
leaving mobile mode or when the drawer is unmounted.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37141&comment_hash=fc1724592e701907cbd1a7834741779d7e265de72720bb78cd213bf1e31a1735&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37141&comment_hash=fc1724592e701907cbd1a7834741779d7e265de72720bb78cd213bf1e31a1735&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
