rusackas commented on code in PR #32958:
URL: https://github.com/apache/superset/pull/32958#discussion_r3717344426
##########
superset/daos/dashboard.py:
##########
@@ -397,6 +397,7 @@ def set_dash_metadata(
md["color_namespace"] = data.get("color_namespace")
md["expanded_slices"] = data.get("expanded_slices", {})
+ md["expand_all_slices"] = data.get("expand_all_slices", False)
Review Comment:
Same note as the other thread on this line, it's a pre-existing pattern
across all the boolean metadata fields, not just this one.
##########
superset-frontend/src/dashboard/actions/dashboardState.ts:
##########
@@ -538,6 +538,7 @@ export function saveDashboardRequest(
? getColorSchemeDomain(colorScheme)
: [],
expanded_slices: data.metadata?.expanded_slices || {},
+ expand_all_slices: data.metadata?.expand_all_slices || false,
Review Comment:
Same story here, || false matches how every other metadata boolean is
defaulted in this action. The real fix for string coercion belongs in the
schema layer, not per-field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
