codeant-ai-for-open-source[bot] commented on code in PR #32958:
URL: https://github.com/apache/superset/pull/32958#discussion_r3717345556
##########
superset/daos/dashboard.py:
##########
@@ -397,6 +397,7 @@ def set_dash_metadata(
md["color_namespace"] = data.get("color_namespace")
md["expanded_slices"] = data.get("expanded_slices", {})
+ md["expand_all_slices"] = data.get("expand_all_slices", False)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag boolean metadata assignments for lacking type normalization
when they follow the existing dashboard metadata handling pattern.
**Applied to:**
- `superset/daos/dashboard.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/src/dashboard/actions/dashboardState.ts:
##########
@@ -538,6 +538,7 @@ export function saveDashboardRequest(
? getColorSchemeDomain(colorScheme)
: [],
expanded_slices: data.metadata?.expanded_slices || {},
+ expand_all_slices: data.metadata?.expand_all_slices || false,
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not require per-field boolean coercion or normalization in this action;
metadata string coercion should be handled in the schema layer, and `|| false`
is acceptable for defaulting here.
**Applied to:**
- `superset-frontend/src/dashboard/actions/dashboardState.ts`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
