codeant-ai-for-open-source[bot] commented on code in PR #32958:
URL: https://github.com/apache/superset/pull/32958#discussion_r3717347191
##########
superset/dashboards/schemas.py:
##########
@@ -197,6 +197,7 @@ class DashboardJSONMetadataSchema(Schema):
# deprecated wrt dashboard-native filters
filter_scopes = fields.Dict()
expanded_slices = fields.Dict()
+ expand_all_slices = fields.Boolean()
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> When reviewing dashboard metadata validation, address permissive boolean
coercion consistently across all Boolean fields rather than flagging only
expand_all_slices.
**Applied to:**
- `superset/dashboards/schemas.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset/dashboards/schemas.py:
##########
@@ -196,6 +196,7 @@ class DashboardJSONMetadataSchema(Schema):
# deprecated wrt dashboard-native filters
filter_scopes = fields.Dict()
expanded_slices = fields.Dict()
+ expand_all_slices = fields.Boolean()
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not require explicit type annotations for schema field declarations
when they follow the existing style in this schema module.
**Applied to:**
- `superset/dashboards/schemas.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
