mikebridge commented on PR #42539: URL: https://github.com/apache/superset/pull/42539#issuecomment-5206833531
@rusackas all five open items are addressed in `23f1617b08` — thread-by-thread replies inline. The short version: - **`type_generic` assertion added** (your named ask), with the fixture switched to wire-shaped pyarrow type names (`timestamp[us]`/`string`/`double`) since that is what `/structure` serialises — a `mapSemanticTypeToGenericDataType` regression now fails the test (control-run verified: breaking the mapper fails it, restoring passes). - **Cross-layer import resolved**: the shared structure helpers moved to `src/utils/semanticViewStructure.ts`; the filter-form utils re-export them, so the diff to existing call sites is nil. - **`as unknown as Dataset` deleted outright** — the fabricated `id`/`datasource_type` fields had no readers, and with them (and `verbose_name: null`) gone, the literal is a structurally valid `Dataset`. - **`as unknown as Metric[]` narrowed, not just cleaned**: the blanket cast was actually hiding a missing required `uuid` (which the wire doesn't carry), not the `verbose_name` typing. It's now `as Omit<Metric, 'uuid'>[] as Metric[]` — the one genuinely absent field is documented, everything else stays compiler-checked. - **Renamed** to `getDatasourceTypeFromDatasourceId`. Verified: 93/93 across the FiltersConfigForm suites, 101/101 across `hooks/apiResources` + utils, 233/234 (1 pre-existing skip) over the wider affected surface incl. both `useDatasetDrillInfo` consumers; full-project `tsc` and pre-commit clean. Disclosure: fixes and replies prepared with AI assistance (Claude), on behalf of and reviewed by @mikebridge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
