rusackas opened a new pull request, #43018: URL: https://github.com/apache/superset/pull/43018
Follow-up to #41250. That PR made SMTP, CSV/dataframe, and Selenium network timeouts configurable so a hung network call can't wedge a report schedule in `WORKING` forever. It missed the webhook notification path: both `requests.post()` calls in `superset/reports/notifications/webhook.py` still hardcoded `timeout=60`. ### SUMMARY Adds `ALERT_REPORTS_WEBHOOK_TIMEOUT` (default `60`, matching the prior hardcoded value) and wires it into both webhook `requests.post()` calls, consistent with the other timeouts #41250 introduced. Also documents the new setting alongside the existing `ALERT_REPORTS_WEBHOOK_HTTPS_ONLY` docs. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (backend config change). ### TESTING INSTRUCTIONS - `pytest tests/unit_tests/reports/notifications/webhook_tests.py` - New test `test_send_forwards_configured_timeout` asserts the configured value is passed through to `requests.post`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
