Copilot commented on code in PR #43018:
URL: https://github.com/apache/superset/pull/43018#discussion_r3754033743
##########
superset/reports/notifications/webhook.py:
##########
@@ -172,6 +172,7 @@ def send(self) -> None:
self._validate_webhook_url(wh_url)
payload = self._get_req_payload()
files = self._get_files()
+ timeout = current_app.config["ALERT_REPORTS_WEBHOOK_TIMEOUT"]
Review Comment:
The retry/backoff explainer comment above still hard-codes `timeout=60` and
"run its full 60s". Since the request timeout is now configurable via
`ALERT_REPORTS_WEBHOOK_TIMEOUT`, this comment can become inaccurate and should
reference the default/configurable timeout instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
