bito-code-review[bot] commented on PR #43018: URL: https://github.com/apache/superset/pull/43018#issuecomment-5246951782
<!-- Bito Reply --> The documentation in `docs/admin_docs/configuration/alerts-reports.mdx` should be updated to reflect that the timeout is configurable via `ALERT_REPORTS_WEBHOOK_TIMEOUT` rather than hard-coded to 60 seconds. The current text in the "Retry Behavior" section incorrectly references a fixed 60-second timeout and "run its full 60s". Suggested update for the documentation: ```markdown Retries are bounded to roughly 120 seconds of cumulative wall-clock time (worst case ~210 seconds, because the bound is checked against the time elapsed before each attempt, so the final request can begin just under the limit and still run its full configured timeout), after which the delivery is abandoned. ``` **docs/admin_docs/configuration/alerts-reports.mdx** ``` Retries are bounded to roughly 120 seconds of cumulative wall-clock time (worst case ~210 seconds, because the bound is checked against the time elapsed before each attempt, so the final request can begin just under the limit and still run its full configured timeout), after which the delivery is abandoned. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
