rusackas commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5248384242
Thanks for pushing this forward! Looks like the review thread already caught something worth resolving: on temporal XY/Mixed charts, the new temporal_column binding doesn't actually replace granularity_sqla as the dashboard time subject, so the range ends up applied to both columns instead of just the one being bound. That seems to undercut the point of the fix, so I'd want that sorted before this goes further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
