aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5262299297
Addressed the substantive feedback from @richardfogaca and @rusackas in `cdf5e8bde56cf33afc4e6125f987530742a8bbdd` (rebased onto the latest `upstream/master` before force-pushing): 1. **Single query-context time subject:** when an explicit `temporal_column` differs from `granularity_sqla`, mapping clears the granularity. This is necessary because `QueryContextFactory._apply_granularity()` otherwise removes/replaces the temporal filter and makes granularity the effective subject. Added regressions for temporal XY, Mixed Timeseries, and categorical Waterfall configurations, and a final `QueryObject` processing assertion proving only `created_at` receives the dashboard range. 2. **One temporal predicate + missing/collision validation:** dataset-context construction and binding now share `is_dataset_column_temporal`, including the numeric `is_dttm` guard. An explicit missing temporal column now fails independently with `MISSING_TEMPORAL_COLUMN`, and saved-metric name collisions no longer suppress the physical temporal-column reference. 3. **Preview provenance:** generated dashboard bindings now carry `_mcp_dashboard_time_filter_subject`. Preview rebinding removes only the prior generated subject, preserving unrelated cached `TEMPORAL_RANGE` filters such as `processed_at`; tests cover replacement, removal, and multi-temporal-filter preservation. 4. **Imports:** removed the redundant inline `SQLAlchemyError` imports and use the module-level import. Validation completed locally: - `66 passed` for the affected dashboard-binding and update-preview test modules - changed-file pre-commit suite passed (mypy, ruff/format, pylint, etc.) - `pre-commit run --all-files` was also executed; repo-wide frontend/audit hooks hit environment-only read-only cache/network failures, and the repo-wide ruff pass reports unrelated pre-existing fixture-name findings. No unrelated files were retained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
