aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5272287689
Follow-up review sweep completed and pushed in `974a2d8` after rebasing again onto latest `upstream/master` (`cc35056` at rebase time). - Added the suggested public normalization regression for `BigNumberChartConfig.temporal_column`, alongside the existing Table coverage. - Replied inline to the no-new-binding suggestion: removing the previous provenance-marked generated binding is intentional, prevents a stale dashboard time subject, and preserves unrelated temporal filters. This is covered by explicit removal and multi-filter preservation regressions. - Rechecked the `ConfigDict(populate_by_name)` notes: they remain non-actionable here because neither `HandlebarsChartConfig` nor `BigNumberChartConfig` declares aliased fields, while aliased nested `ColumnRef` fields retain their own configuration. Changing unrelated model parsing behavior would be out-of-scope churn. Validation: - Changed-file pre-commit suite passed, including mypy, ruff/format, and pylint. - Required `pre-commit run --all-files` was executed. Backend hooks passed; environment-only frontend/Helm/audit hooks could not run because this checkout has no frontend dependencies/helm-docs and the runner's npm/cache setup failed. CI previously passed all required checks and the new push has started a fresh run. - The affected tests passed before the latest upstream rebase (66 tests). After the rebase, local test collection is blocked by the environment's older `sqlglot` lacking the newly referenced `singlestore` dialect; the added change is a test-only parametrization and CI will validate it with the current locked environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
