madhushreeag commented on PR #43028:
URL: https://github.com/apache/superset/pull/43028#issuecomment-5257036294
> The flagged issue is correct. The test currently mocks the `super` lookup
to force an error, which bypasses the actual `PLAYWRIGHT_AVAILABLE` check in
`PooledBaseScreenshot`. To properly test this, you should patch the
availability state itself (e.g., by mocking the module-level constant or the
configuration check) to ensure the code path that handles missing Playwright is
actually exercised.
>
> Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
the super patch was replaced with
@patch("superset.utils.webdriver.PLAYWRIGHT_AVAILABLE", False) so the test now
exercises the real availability check in WebDriverPlaywright.get_screenshot()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
