madhushreeag commented on code in PR #43028: URL: https://github.com/apache/superset/pull/43028#discussion_r3761979124
########## superset/mcp_service/screenshot/webdriver_pool.py: ########## @@ -16,422 +16,30 @@ # under the License. """ -WebDriver connection pooling for improved screenshot performance -""" - -import logging -import signal -import threading -import time -from contextlib import contextmanager -from dataclasses import dataclass -from queue import Empty, Full, Queue -from typing import Any, Dict, Generator - -from flask import current_app -from selenium.common.exceptions import WebDriverException -from selenium.webdriver.remote.webdriver import WebDriver - -from superset.utils.webdriver import WebDriverSelenium, WindowSize - -logger = logging.getLogger(__name__) - - -class WebDriverCreationError(Exception): - """Exception raised when WebDriver creation times out""" - - pass +Stub module retained for import compatibility after Selenium removal. Review Comment: Done! Removed webdriver_pool.py, pooled_screenshot.py, and webdriver_config.py entirely. All callers updated to use BaseScreenshot, ChartScreenshot, and DashboardScreenshot directly from superset.utils.screenshots. The __init__.py has been cleaned up accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
