madhushreeag commented on PR #43028: URL: https://github.com/apache/superset/pull/43028#issuecomment-5257415991
> ### Code Review Agent Run #a7eb20 > Actionable Suggestions - 0 > Additional Suggestions - 5 > Filtered by Review Rules > Review Details > Bito Usage Guide > AI Code Review powered by [<img alt="Bito Logo" width="50" height="20" src="https://camo.githubusercontent.com/810f9c950a15f18a9a21d4e214820ef360ea3b08a4b5dea95d24529fffd09ed6/68747470733a2f2f6269746f2e61692f77702d636f6e74656e742f75706c6f6164732f323032332f31302f4c6f676f2d4269746f2d426c61636b2d63726f707065642e737667";>](https://bito.ai/) 1. Removed the duplicate return results on line 427. 2. logger was never referenced in the stub implementation. Removed the import. 3. Updated the docstring to reference only ChartScreenshot since DashboardScreenshot is no longer tested in that class. 4. Removed SCREENSHOT_WAIT_FOR_ERROR_MODAL_VISIBLE and SCREENSHOT_WAIT_FOR_ERROR_MODAL_INVISIBLE from all test mock config dictionaries. These are Selenium-only keys documented as removed in UPDATING.md and no longer referenced in production code. 5. Removed "--headless" from the default value entirely since Playwright runs headless by default and passing it explicitly adds no value. WEBDRIVER_OPTION_ARGS now defaults to []. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
