gabotorresruiz commented on PR #43066: URL: https://github.com/apache/superset/pull/43066#issuecomment-5258753015
Thanks for the thorough pass, genuinely useful. Fixed the blocker at the root in `validate_chart_dataset` (`skip_base_filter=not check_access`) and added tests that actually fail without the fix, for the guest existence path, the row_limit coercion, and the slug branch. Replies inline, all threads addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
