bito-code-review[bot] commented on code in PR #43066:
URL: https://github.com/apache/superset/pull/43066#discussion_r3768912286
##########
superset/dashboards/filters.py:
##########
@@ -270,7 +236,6 @@ def _apply_legacy(self, query: Query) -> Query:
or_(
Dashboard.id.in_(editor_ids_query),
Dashboard.id.in_(datasource_perm_query),
- *feature_flagged_filters,
*extra_access_filters,
)
)
Review Comment:
<!-- Bito Reply -->
The removal of the dead method is appropriate. Since the conditional logic
that previously invoked this method has been removed, the method is no longer
reachable and its deletion correctly reduces code complexity and maintenance
overhead.
**superset/dashboards/filters.py**
```
or_(
Dashboard.id.in_(editor_ids_query),
Dashboard.id.in_(datasource_perm_query),
- *feature_flagged_filters,
*extra_access_filters,
)
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
