bito-code-review[bot] commented on code in PR #43066:
URL: https://github.com/apache/superset/pull/43066#discussion_r3762586477
##########
superset/dashboards/filters.py:
##########
@@ -270,7 +236,6 @@ def _apply_legacy(self, query: Query) -> Query:
or_(
Dashboard.id.in_(editor_ids_query),
Dashboard.id.in_(datasource_perm_query),
- *feature_flagged_filters,
*extra_access_filters,
)
)
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dead method post-refactor</b></div>
<div id="fix">
The `_apply_legacy` method is dead code. The conditional
`is_feature_enabled("ENABLE_VIEWERS")` that was its only caller was removed by
this diff. The method body now only accumulates complexity and maintenance
burden with zero runtime benefit.
</div>
</div>
<small><i>Code Review Run #a1a7e2</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
