codeant-ai-for-open-source[bot] commented on code in PR #42895:
URL: https://github.com/apache/superset/pull/42895#discussion_r3761937130
##########
superset/db_engine_specs/duckdb.py:
##########
@@ -198,6 +200,16 @@ class DuckDBEngineSpec(DuckDBParametersMixin,
BaseEngineSpec):
sqlalchemy_uri_placeholder = "duckdb:////path/to/duck.db"
supports_multivalues_insert = True
+ # Verified against a live duckdb instance (in-process, no server needed),
+ # including under GROUPING SETS: the grand total correctly reflects every
+ # row, not an aggregate-of-aggregates. Values match postgres/mysql exactly
Review Comment:
**Suggestion:** The verification comment is factually incorrect: MySQL does
not support `MEDIAN`, so DuckDB's `MEDIAN` result cannot have been compared
against MySQL. This can mislead future maintainers into treating the DuckDB
median implementation as cross-engine verified; document the comparison only
for aggregates supported by both engines or explicitly exclude MySQL from the
claim. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Verification comment ambiguously describes cross-engine coverage.
- โ ๏ธ Future maintainers may misunderstand MySQL's unsupported MEDIAN
capability.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0d06f50e0d6140cab53a7ea00e3027f7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0d06f50e0d6140cab53a7ea00e3027f7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/duckdb.py
**Line:** 203:205
**Comment:**
*Comment Mismatch: The verification comment is factually incorrect:
MySQL does not support `MEDIAN`, so DuckDB's `MEDIAN` result cannot have been
compared against MySQL. This can mislead future maintainers into treating the
DuckDB median implementation as cross-engine verified; document the comparison
only for aggregates supported by both engines or explicitly exclude MySQL from
the claim.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42895&comment_hash=ed0d6710dc52317b6f97fff45824ee045243daa52f9bc6fc41f96ca434106c62&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42895&comment_hash=ed0d6710dc52317b6f97fff45824ee045243daa52f9bc6fc41f96ca434106c62&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
