sha174n commented on PR #42895:
URL: https://github.com/apache/superset/pull/42895#issuecomment-5281443063
One consistency gap: MariaDBEngineSpec, AuroraMySQLEngineSpec /
AuroraPostgresEngineSpec (and their DataAPI variants) and TimescaleDBEngineSpec
subclass the MySQL/Postgres specs, so they inherit the new extended aggregates
without being explicitly verified — which cuts against this PR's own "opt-in
only once verified per engine" principle and the disable-list you applied to
cockroach/greenplum/hana/etc. The test_extended_aggregations_unverified guard
also omits those inherited specs, so the gap passes CI unnoticed. Could we
either reset them to {} like the others (or justify why they're exempt) and
extend the guard test to cover them?
Smaller notes: the frontend dropdown shows the raw enum
(STDDEV_SAMP/VAR_SAMP) — a display-label map ("Sample Std Dev"/"Sample
Variance") would read better; and utils/core.py leaves stale STDDEV/VARIANCE
keys in the type map alongside the new ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
