madhushreeag commented on PR #43028: URL: https://github.com/apache/superset/pull/43028#issuecomment-5259291407
> ### Code Review Agent Run #91380b > Actionable Suggestions - 0 > Additional Suggestions - 3 > Filtered by Review Rules > Review Details > Bito Usage Guide > AI Code Review powered by [<img alt="Bito Logo" width="50" height="20" src="https://camo.githubusercontent.com/810f9c950a15f18a9a21d4e214820ef360ea3b08a4b5dea95d24529fffd09ed6/68747470733a2f2f6269746f2e61692f77702d636f6e74656e742f75706c6f6164732f323032332f31302f4c6f676f2d4269746f2d426c61636b2d63726f707065642e737667";>](https://bito.ai/) 1. Wrapped the URL loop in a try/finally that calls _browser_manager._cleanup() to release the Chromium process even if a BaseException (e.g. KeyboardInterrupt) escapes the inner except Exception handler. 2. webdriver_pool.py has been deleted entirely as part of removing the Selenium stubs. The singleton concern is moot, Playwright uses _browser_manager which is already a module-level process-scoped singleton in webdriver.py, cleaned up via atexit. 3. Moved from superset.utils.machine_auth import MachineAuthProvider to the top of the file and removed the inline import from inside test_authenticate_browser_context_uses_override. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
