aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5297411985
Addressed Richard’s remaining Big Number Total feedback in `537a2a4e1f`: - fallback temporal subjects now record generated-filter provenance - provenance is recorded only for the canonical neutral `No filter` binding, preserving user-authored ranges - added coverage for the no-`main_dttm_col` first-temporal-column fallback and rebinding that fallback from `order_date` to `created_at` Validation: staged-file `pre-commit run` passed, including mypy, ruff, ruff-format, and pylint. Targeted pytest remains locally blocked by the environment’s outdated `sqlglot` lacking `sqlglot.dialects.singlestore`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
