bikash-barnwal opened a new pull request, #43196:
URL: https://github.com/apache/superset/pull/43196
### SUMMARY
In the role modal, the **Permissions** dropdown inherits the trigger's
width, so options are truncated. Permission labels are long — `all datasource
access on all_datasource_access`, `can write on DashboardFilterStateRestApi` —
and once cut off, entries become impossible to tell apart, which is exactly
what the screenshot in #40430 shows.
`popupMatchSelectWidth={false}` lets the popup size to its content instead.
`AsyncSelect` forwards unrecognized props to the antd `Select`, so no wrapper
change is required.
Scoped to the permissions field on purpose: the neighbouring Users and
Groups selects show short names and are not affected.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: dropdown is trigger-width; every permission is cut off mid-label.
After: the dropdown widens to fit the longest option.
### TESTING INSTRUCTIONS
```bash
cd superset-frontend
npm run test -- src/features/roles
```
45 tests across 5 suites still pass.
**No unit test accompanies this change, deliberately.** jsdom never applies
antd's popup sizing, so a computed-style assertion passes with or without the
fix — I wrote one, confirmed it was vacuous, and removed it rather than leave a
test that proves nothing. The alternative, mocking
`@superset-ui/core/components` to inspect the prop, breaks that barrel's
circular imports (`Cannot read properties of undefined (reading
'ActionButton')`). Verification is visual: open **Settings → List Roles →
Edit**, click **Permissions**, and confirm long entries are fully readable.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #40430
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
