Copilot commented on code in PR #43196:
URL: https://github.com/apache/superset/pull/43196#discussion_r3797579411
##########
superset-frontend/src/features/roles/RoleFormItems.tsx:
##########
@@ -72,6 +72,12 @@ export const PermissionsField = ({
.replace(/_/g, ' ')
.includes(input.toLowerCase().replace(/_/g, ' '))
}
+ // Permission labels are long ("all datasource access on all_datasource
+ // _access", "can write on DashboardFilterStateRestApi"), and the
+ // dropdown otherwise inherits the trigger's width inside the modal, so
+ // every option was truncated to the point of being indistinguishable.
+ // Let the popup size to its content instead. See #40430.
Review Comment:
The comment splits `all_datasource_access` across lines as `all_datasource`
+ ` _access`, which makes the example string inaccurate and harder to read.
Consider keeping the permission label intact (or split without inserting a
space) so the comment matches the real value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
