codeant-ai-for-open-source[bot] commented on code in PR #43196:
URL: https://github.com/apache/superset/pull/43196#discussion_r3845589106
##########
superset-frontend/src/features/roles/RoleFormItems.tsx:
##########
@@ -72,6 +72,12 @@ export const PermissionsField = ({
.replace(/_/g, ' ')
.includes(input.toLowerCase().replace(/_/g, ' '))
}
+ // Permission labels are long ("all datasource access on
all_datasource_access",
+ // "can write on DashboardFilterStateRestApi"), and the dropdown
otherwise
+ // inherits the trigger's width inside the modal, so every option was
truncated
+ // to the point of being indistinguishable. Let the popup size to its
content
+ // instead. See #40430.
+ popupMatchSelectWidth={false}
Review Comment:
**Suggestion:** Disabling width matching makes the popup size to the longest
option without any maximum width or wrapping constraint. Because this popup is
mounted inside `.ant-modal-container`, sufficiently long permission labels can
extend beyond the modal or viewport and be clipped, leaving options
inaccessible. Constrain the popup to the available viewport/modal width and
allow labels to wrap, or use a popup container that can safely overflow the
modal. [css layout issue]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Long permission options can remain partially inaccessible.
- ⚠️ Narrow-screen role editing may require horizontal scrolling.
- ⚠️ Popup can extend beyond the modal viewport.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ec8ec16c10f0477ab05272d3fec64700&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ec8ec16c10f0477ab05272d3fec64700&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/features/roles/RoleFormItems.tsx
**Line:** 80:80
**Comment:**
*Css Layout Issue: Disabling width matching makes the popup size to the
longest option without any maximum width or wrapping constraint. Because this
popup is mounted inside `.ant-modal-container`, sufficiently long permission
labels can extend beyond the modal or viewport and be clipped, leaving options
inaccessible. Constrain the popup to the available viewport/modal width and
allow labels to wrap, or use a popup container that can safely overflow the
modal.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43196&comment_hash=c0583db02d4b12ca1ff19252eb18278017ccf59414083e77ea26fa3cd3b7c588&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43196&comment_hash=c0583db02d4b12ca1ff19252eb18278017ccf59414083e77ea26fa3cd3b7c588&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
