sadpandajoe opened a new pull request, #43264:
URL: https://github.com/apache/superset/pull/43264
### SUMMARY
Fixes #43200. The flaky test at recently-archived.spec.ts:192 ("shows an
empty message and no rows when the search matches nothing") races the list's
first-page load: it waits only for the `archived-list-view` container to mount
before typing a search query, so the keystroke can be swallowed before the
filter machinery is wired up (the container is visible before data loads).
Rather than just patch the wait, I reviewed the whole `recently-archived/` e2e
suite against the existing `ArchivedList.test.tsx` Jest/RTL coverage and found
this test — plus two siblings — never actually needed a real backend or
browser, so they move to deterministic component tests instead of race-prone
e2e:
- `recently-archived.spec.ts`: removed the flaky empty-search test and the
"restoring an already-restored row surfaces an error" test; both now live in
`ArchivedList.test.tsx` as Jest tests with mocked responses (empty list result
/ 404 restore, respectively).
- `delete-modal.spec.ts`: removed entirely — its one test only asserted
feature-flag-gated confirm-dialog copy and never deleted or archived anything
real; moved to `ChartList.test.tsx`.
- The three real soft-delete-restore e2e tests, the real permanent-delete
e2e test, and `menu-link.spec.ts` are untouched — they exercise real backend
state changes and real app-shell routing, which e2e is for.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — test-only change, no UI/behavior change.
### TESTING INSTRUCTIONS
- `cd superset-frontend && npx jest src/pages/ArchivedList
src/pages/ChartList` — 5 suites, 94 tests, all passing.
- `npx playwright test --list playwright/tests/recently-archived/` — lists
the 5 remaining tests across `menu-link.spec.ts` and
`recently-archived.spec.ts` (down from 7 across 3 files), confirming valid
syntax after the removals.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #43200
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
