bito-code-review[bot] commented on PR #43264: URL: https://github.com/apache/superset/pull/43264#issuecomment-5320462645
<!-- Bito Reply --> The flagged issue is correct. The test `shows an empty message and no rows when the search matches nothing` is fragile because it relies on the list endpoint returning an empty result for both the initial load and the filtered request, allowing the test to pass even if the search functionality is broken. To resolve this, you should ensure the initial request returns data, configure the filtered request to return an empty result, and verify that the search request was actually triggered before asserting the empty state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
