yousoph commented on code in PR #43264:
URL: https://github.com/apache/superset/pull/43264#discussion_r3824398468
##########
superset-frontend/src/pages/ArchivedList/ArchivedList.test.tsx:
##########
@@ -204,6 +205,31 @@ test('restore failure surfaces an error and leaves the row
in place', async () =
expect(screen.getByText('Deleted Chart One')).toBeInTheDocument();
});
+test('restoring an already-restored row (404) surfaces an error without
crashing', async () => {
Review Comment:
Optional: this exercises the same single `catch → addDangerToast` path as
the existing 422 test above (the component treats any non-200 restore
identically), so it's near-duplicate coverage. The genuinely new value here is
the explicit toast text/count assertion — that could just as easily be folded
into the 422 test. Harmless as-is, just flagging in case you'd rather keep one
restore-failure test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
