SBIN2010 opened a new pull request, #43370: URL: https://github.com/apache/superset/pull/43370
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Adds an opt-in control that applies existing conditional formatting rules to the summary row in table charts. Previously, color rules ran on data cells only. The totals row stayed unformatted. This change introduces a checkbox, Apply conditional formatting to totals, defaulting to off so existing charts keep their current look. When enabled, the same conditional formatting rules (background / text color) are applied to totals-row metric cells: Table Table (AG Grid) The control is visible only when totals are enabled - Show summary. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> <img width="2196" height="1326" alt="Снимок экрана от 2026-08-21 00-17-39" src="https://github.com/user-attachments/assets/15ff3285-2d11-479a-86a5-a6b9c5cff23a"; /> <img width="2196" height="1326" alt="Снимок экрана от 2026-08-21 00-17-39" src="https://github.com/user-attachments/assets/06574d6b-2408-4c15-a0f7-1500f1257e67"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Open a Table or Table (AG Grid) chart in Explore, enable Show summary, and add a numeric conditional formatting rule. Confirm the totals row is unchanged while Apply conditional formatting to totals is off. Enable the flag and confirm matching totals cells get the same background/text color as data cells. Save the chart, add it to a dashboard, and confirm the flag persists after reload. run test npm run test superset-frontend/plugins/plugin-chart-ag-grid-table/test/utils/getCellStyle.test.ts npm run test superset-frontend/plugins/plugin-chart-ag-grid-table/test/controlPanel.test.ts npm run test superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
