codeant-ai-for-open-source[bot] commented on code in PR #43370:
URL: https://github.com/apache/superset/pull/43370#discussion_r3825543955
##########
superset-frontend/plugins/plugin-chart-table/src/transformProps.ts:
##########
@@ -821,6 +822,7 @@ const transformProps = (
emitCrossFilters,
onChangeFilter,
columnColorFormatters,
+ applyConditionalFormattingToTotals,
Review Comment:
**Suggestion:** When this flag is enabled, totals formatting is driven only
by `columnColorFormatters`, but the preceding formatter construction explicitly
removes the Green and Red conditional-formatting schemes. Those schemes are
handled separately through `basicColorColumnFormatters` for data cells, while
the totals renderer does not consume that formatter, so enabling this option
silently fails to format totals for Green/Red conditional rules. Include the
basic conditional formatter path when constructing totals styling, or route all
conditional-formatting schemes through the totals formatter. [incomplete
implementation]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Green/Red rules fail on enabled totals rows.
- ⚠️ Data and totals cells display inconsistent formatting.
- ⚠️ The new totals-formatting option is incomplete.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
**Line:** 825:825
**Comment:**
*Incomplete Implementation: When this flag is enabled, totals
formatting is driven only by `columnColorFormatters`, but the preceding
formatter construction explicitly removes the Green and Red
conditional-formatting schemes. Those schemes are handled separately through
`basicColorColumnFormatters` for data cells, while the totals renderer does not
consume that formatter, so enabling this option silently fails to format totals
for Green/Red conditional rules. Include the basic conditional formatter path
when constructing totals styling, or route all conditional-formatting schemes
through the totals formatter.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43370&comment_hash=d5c3763c658f2798b147d493e877ae26877ae5f1e9c90e7b55b3d7f4f52eef4e&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43370&comment_hash=d5c3763c658f2798b147d493e877ae26877ae5f1e9c90e7b55b3d7f4f52eef4e&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
