bito-code-review[bot] commented on PR #43370: URL: https://github.com/apache/superset/pull/43370#issuecomment-5362074883
<!-- Bito Reply --> The issue flagged in the review comment is correct. The current implementation of `conditional_formatting_totals` in `superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx` only consumes `columnColorFormatters` and ignores `basicColorColumnFormatters`, which are used for Green/Red conditional formatting rules. To resolve this, you should update `getConditionalFormattingColors` to also process `basicColorColumnFormatters` or ensure that all conditional formatting rules are consolidated into `columnColorFormatters` before being passed to the totals renderer. I have validated the issue and the proposed fix direction. Would you like me to fetch all other comments on this PR to check if there are other issues you would like to address? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
