EnxDev opened a new pull request, #43454: URL: https://github.com/apache/superset/pull/43454
### SUMMARY The "View as table" (Chart Data) modal on a dashboard chart could render with its results grid collapsed to a thin sliver, with the "Edit chart"/ "Close" buttons sitting on top of or immediately below it instead of below a properly filled grid. Root cause: `ResultsPaneOnDashboard`'s `<Tabs>` didn't pass `fullHeight` (unlike its sibling usages in `TabsRenderer`/`DashboardContainer`), so `.ant-tabs-content` never received `height: 100%` and collapsed to its intrinsic size. Because the collapsed container reports a height of `0` to the `ResizeObserver` in `useGridHeight`, and that hook only updates its state `if (h > 0)`, the results grid silently fell back to a hardcoded 400px height that's disconnected from the modal's real available space. In a large default-sized modal this just wasted blank space; once the modal is smaller than 400px of available body height (e.g. resized down), the grid overflows and visually collides with the footer buttons. Fix: pass `fullHeight` to the `<Tabs>` in `ResultsPaneOnDashboard`,restoring the height chain so the grid's container always reports its real size and the grid tracks it correctly at any modal size. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://github.com/user-attachments/assets/457483af-89a5-4e0d-afcd-48f4258dc278 ### TESTING INSTRUCTIONS 1. Build a Table chart on a single metric (no groupby) and add it to a dashboard. 2. On the dashboard, open the chart's context menu and choose "View as table" (Chart Data). 3. Resize the modal smaller using its bottom-right drag handle. 4. Confirm the results grid always fills the modal body without overflowing into the footer buttons, at both default and resized modal heights. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
