msyavuz commented on code in PR #43454:
URL: https://github.com/apache/superset/pull/43454#discussion_r3845166832
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -88,7 +88,12 @@ export const ResultsPaneOnDashboard = ({
return (
<Wrapper>
- <Tabs activeKey={activeTabKey} onChange={setActiveTabKey} items={items}
/>
+ <Tabs
+ fullHeight
Review Comment:
`fullHeight` already emits `height: 100%` on `.ant-tabs` and
`.ant-tabs-body`, which `Wrapper` also hardcodes at L31-37 — drop those two
rules? `.ant-tabs-content` was the only missing link.
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -88,7 +88,12 @@ export const ResultsPaneOnDashboard = ({
return (
<Wrapper>
- <Tabs activeKey={activeTabKey} onChange={setActiveTabKey} items={items}
/>
+ <Tabs
+ fullHeight
+ activeKey={activeTabKey}
+ onChange={setActiveTabKey}
+ items={items}
+ />
Review Comment:
Worth a `toHaveStyleRule('height', '100%', { target: '.ant-tabs-content' })`
here so removing `fullHeight` fails loudly? The fix is one prop with no
jsdom-observable behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
