EnxDev commented on PR #43454: URL: https://github.com/apache/superset/pull/43454#issuecomment-5408899559
Thanks for the reviews! Addressed in 3036bad6e7: - **@msyavuz** – dropped the now-redundant `.ant-tabs`/`.ant-tabs-body` height rules from `Wrapper` (confirmed `fullHeight` already sets both), and added a regression test spying on the `Tabs` call args to assert `fullHeight` is always passed (couldn't use `toHaveStyleRule` here — jest's babel config doesn't set `importSource: '@emotion/react'` the way webpack's does, so the `css` prop never compiles under jsdom in this repo). - **CodeAnt / Bito** – confirmed the stale `activeTabKey` issue is real (a mixed chart shrinking from N to fewer query results can orphan the active tab, rendering blank). Extracted `DataTablesPane`'s existing `getStaleResultsTabFallback` helper into a shared `utils.ts` and wired the same reconciliation into `ResultsPaneOnDashboard`, with a new test covering the fallback. All 34 tests in `DataTablesPane` pass, pre-commit is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
