sadpandajoe commented on code in PR #43502: URL: https://github.com/apache/superset/pull/43502#discussion_r3857496538
########## tests/testcontainers/db_engine_specs/test_cockroachdb.py: ########## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Tests db_engine_specs.cockroachdb against a real CockroachDB instance, +spun up on demand via testcontainers. Run nightly (see +.github/workflows/nightly-testcontainers.yml), not on every merge -- these +exercise real SQL execution and dialect introspection, which mocked unit +tests structurally cannot. +""" + +from collections.abc import Iterator + +import pytest +from sqlalchemy import ( + Column, + create_engine, + inspect, + Integer, + MetaData, + Table as SATable, +) +from sqlalchemy.engine import Engine + +from superset.db_engine_specs.cockroachdb import CockroachDbEngineSpec +from superset.sql.parse import Table + +pytest.importorskip("testcontainers.community.cockroachdb") Review Comment: Each matrix job runs only this module, so `importorskip` turns a missing or broken required testcontainers driver into a successful job with zero tests instead of reporting that the CI environment is misconfigured. Should these dedicated CI tests fail when their required driver cannot import? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
