rusackas commented on code in PR #43502:
URL: https://github.com/apache/superset/pull/43502#discussion_r3869534404
##########
requirements/development.in:
##########
@@ -16,5 +16,8 @@
# specific language governing permissions and limitations
# under the License.
#
--e
.[development,bigquery,druid,duckdb,fastmcp,gevent,gsheets,mysql,postgres,presto,prophet,trino,thumbnails]
+-e
.[development,bigquery,cockroachdb,crate,db2,druid,duckdb,elasticsearch,fastmcp,gevent,gsheets,mssql,mysql,oracle,postgres,presto,prophet,trino,thumbnails]
Review Comment:
Good catch. Scoped `db2` out of the baseline dev install since `ibm-db` has
no arm64 wheel. The `testcontainers` CI job now installs it directly for just
its own db2 leg.
##########
superset/db_engine_specs/cockroachdb.py:
##########
@@ -44,7 +44,7 @@ class CockroachDbEngineSpec(PostgresEngineSpec):
DatabaseCategory.TRADITIONAL_RDBMS,
DatabaseCategory.OPEN_SOURCE,
],
- "pypi_packages": ["cockroachdb"],
+ "pypi_packages": ["sqlalchemy-cockroachdb"],
Review Comment:
Added `psycopg2-binary` to the `pypi_packages` list alongside
`sqlalchemy-cockroachdb`.
##########
tests/testcontainers/db_engine_specs/test_cockroachdb.py:
##########
@@ -0,0 +1,98 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+Tests db_engine_specs.cockroachdb against a real CockroachDB instance,
+spun up on demand via testcontainers. Run nightly (see
+.github/workflows/nightly-testcontainers.yml), not on every merge -- these
Review Comment:
Fixed, those three docstrings point at `testcontainers.yml` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
