sadpandajoe commented on code in PR #43460:
URL: https://github.com/apache/superset/pull/43460#discussion_r3858104007
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -594,9 +618,15 @@ const Select = forwardRef(
const handleSelectAll = useCallback(() => {
if (isSingleMode) return;
- const optionsToSelect = isSearching
+ const searchScopedOptions = isSearching
? visibleOptions.filter(option => !option.isNewOption)
: enabledOptions;
+ // When stableSelectAll is on, always select the full eligible set
+ // regardless of any active search, so "Select all" targets the whole
+ // column rather than the search-filtered subset.
+ const optionsToSelect = stableSelectAll
Review Comment:
After selecting the full option set while the search shows only a subset,
deselecting one visible option can make `selectAllMode` treat the normal change
as the legacy select-all sentinel and emit an empty filter. Could this state
detection use the same full option set in `stableSelectAll` mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
