sadpandajoe commented on code in PR #43460:
URL: https://github.com/apache/superset/pull/43460#discussion_r3868365771
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -293,6 +300,19 @@ const Select = forwardRef(
[visibleOptions],
);
+ // The stable, full-set counterpart of enabledOptions: every
bulk-selectable
+ // option across the entire (search-independent) option set. Used when
+ // stableSelectAll is on so the "Select all" action and visibility stay
+ // pinned to the full column while a search narrows visibleOptions. Gated
on
+ // stableSelectAll so consumers that don't use the feature skip the filter.
+ const fullSelectAllOptions = useMemo(
+ () =>
+ stableSelectAll
+ ? fullSelectOptions.filter(isBulkSelectable)
Review Comment:
With grouped options, `fullSelectOptions` still contains group nodes rather
than their children, so this filter finds no eligible values and hides both
bulk actions. Could this derive the full selectable set from the group children
as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
