sadpandajoe commented on code in PR #43460:
URL: https://github.com/apache/superset/pull/43460#discussion_r3878192717
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -293,6 +311,27 @@ const Select = forwardRef(
[visibleOptions],
);
+ // The full (search-independent) option set flattened to its leaf options,
so
+ // the stableSelectAll bulk machinery treats grouped columns the same as
flat
+ // ones. Gated on stableSelectAll so consumers that don't use the feature
skip
+ // the work; a flat list is returned unchanged either way.
+ const flatFullSelectOptions = useMemo(
+ () =>
+ stableSelectAll
+ ? flattenGroupedOptions(fullSelectOptions)
Review Comment:
When `stableSelectAll` selects grouped options, the callback still builds
option metadata from the unflattened group nodes and sends an empty options
array alongside the selected values. Could this use the flattened full option
set as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
