bito-code-review[bot] commented on PR #43648:
URL: https://github.com/apache/superset/pull/43648#issuecomment-5453816416
<!-- Bito Reply -->
The removal of the `height: 100%` CSS rules for `.ant-tabs` and
`.ant-tabs-body` in `ResultsPaneOnDashboard.tsx` is indeed part of this PR's
changes. As noted, without these rules or an equivalent mechanism like a
`fullHeight` prop, the tab body will default to its content height, which may
cause layout issues if the container expects a fixed or percentage-based
height. If the intention is to maintain the previous layout behavior, ensuring
that the necessary height constraints are applied—either through the mentioned
prop or by retaining the CSS—is recommended.
**superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx**
```
- .ant-tabs {
- height: 100%;
- }
-
- .ant-tabs-body {
- height: 100%;
- }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
