EnxDev commented on code in PR #43648:
URL: https://github.com/apache/superset/pull/43648#discussion_r3901650556


##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -28,14 +29,6 @@ const Wrapper = styled.div`
   flex-direction: column;
   height: 100%;
 
-  .ant-tabs {
-    height: 100%;
-  }
-
-  .ant-tabs-body {
-    height: 100%;
-  }
-
   .ant-tabs-content {

Review Comment:
   Good catch, thanks. Restored the `.ant-tabs` / `.ant-tabs-body` height rules 
in d14c6a8496d00db574e6ffde6aad89792a8de115 — #43454 hasn't landed yet, so 
dropping them prematurely would collapse the tab body to content height.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to