msyavuz commented on code in PR #43648:
URL: https://github.com/apache/superset/pull/43648#discussion_r3881426854
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -28,14 +29,6 @@ const Wrapper = styled.div`
flex-direction: column;
height: 100%;
- .ant-tabs {
- height: 100%;
- }
-
- .ant-tabs-body {
- height: 100%;
- }
-
.ant-tabs-content {
Review Comment:
This drops the `.ant-tabs` / `.ant-tabs-body` `height: 100%` rules that
master relies on (from #42018), and this branch doesn't carry the `fullHeight`
prop from #43454 that would replace them — so the tab body collapses to content
height unless #43454 lands first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
