EnxDev commented on code in PR #43719:
URL: https://github.com/apache/superset/pull/43719#discussion_r3907105274
##########
superset/datasets/api.py:
##########
@@ -1757,6 +1757,8 @@ def get_drill_info(self, pk: int, **kwargs: Any) ->
Response:
"columns.column_name",
"columns.verbose_name",
"columns.groupby",
+ "metrics.metric_name",
Review Comment:
Could we also load the verbose map when canViewTable is true?
SliceHeaderControls skips useDatasetDrillInfo unless canDrillToDetail is
granted, but “View as table” has its own permission. That means users without
drill access—including the default Gamma role—still get an empty map and see
raw metric names. Decoupling label loading from drill permissions, plus a test
with only can_view_chart_as_table, should cover that path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
