EnxDev commented on code in PR #43719:
URL: https://github.com/apache/superset/pull/43719#discussion_r3915356679
##########
superset/datasets/api.py:
##########
@@ -1834,6 +1834,8 @@ def get_drill_info(self, pk: int, **kwargs: Any) ->
Response:
"columns.column_name",
"columns.verbose_name",
"columns.groupby",
Review Comment:
Could we account for column/metric name collisions here? `createVerboseMap`
writes columns first and metrics second into one object, and the database only
enforces uniqueness within each list. An unused metric can therefore overwrite
the label for a selected column. For example, a `revenue` column labeled
“Revenue” plus an unused metric also named `revenue` labeled “Revenue %” makes
a column-only table show “Revenue %”. Making label resolution aware of the
fields used by the chart would avoid that regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
