Re: [PR] fix(echarts-timeseries): convert xAxisLabelInterval string '0' to number 0 [superset]

Wed, 02 Sep 2026 03:48:41 -0700 


codeant-ai-for-open-source[bot] commented on code in PR #43729:
URL: https://github.com/apache/superset/pull/43729#discussion_r3913279426


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1254,7 +1254,7 @@ export default function transformProps(
     showMaxLabel,
     xAxisType,
     xAxisLabelRotation,
-    xAxisLabelInterval,
+    xAxisLabelInterval === '0' ? 0 : xAxisLabelInterval,

Review Comment:
   **Suggestion:** With pinned temporal ticks, the shared utility still enables 
`hideOverlap`, so numeric `0` can suppress crowded labels and the β€œAll” option 
still fails to show every label. [logic error]
   
   **Assessment:** 🟠 `Major` Β· πŸ” `Occurrence: Sometimes`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=10c3e6f3f3624770a4ed9e1a91d7f0dd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=10c3e6f3f3624770a4ed9e1a91d7f0dd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent πŸ€– </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** 
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
   **Line:** 1257:1257
   **Comment:**
        *Logic Error: With pinned temporal ticks, the shared utility still 
enables `hideOverlap`, so numeric `0` can suppress crowded labels and the β€œAll” 
option still fails to show every label.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43729&comment_hash=ac86a3977cb16a67928f7698299265942b31809f0fbdde219cb59f6f0d7f46e6&reaction=like'>πŸ‘</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43729&comment_hash=ac86a3977cb16a67928f7698299265942b31809f0fbdde219cb59f6f0d7f46e6&reaction=dislike'>πŸ‘Ž</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to